Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update teal.slice version #1414

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Update teal.slice version #1414

merged 3 commits into from
Nov 19, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Nov 14, 2024

Once this was merged in teal.slice and the version was bumped to 0.5.1.9013 insightsengineering/teal.slice#622

We now allow non-alphabetical non-standard names in filter panel.
Without it, some tests break. Below is for teal.slice 0.5.1.9012

data = within(
  teal.data::teal_data(),
  {
    iris <- iris
    mtcars <- mtcars
    `_a variable with spaces_` <- "new_column" # nolint: object_name.
    iris <- cbind(iris, data.frame(`_a variable with spaces_`))
  }
)
teal_data_to_filtered_data(data)

Error in check_simple_name(dataname) : 
  name '_a variable with spaces_' must only contain alphanumeric characters (with underscores) and the first character must be an alphabetic character
Called from: check_simple_name(dataname)

@m7pr
Update teal.slice
a65fe5c 
Signed-off-by: Marcin <[email protected]>
@m7pr m7pr added the core label Nov 14, 2024
@m7pr m7pr requested review from averissimo and gogonzo November 14, 2024 14:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  47      11  76.60%   27, 29, 41, 52-59
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             99      42  57.58%   150-159, 161, 173-194, 219-222, 229-235, 238-239, 241
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             203      37  81.77%   26-54, 68, 78, 238, 269-273
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 74       0  100.00%
R/module_nested_tabs.R              236      91  61.44%   40-142, 174, 199-201, 320, 360
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 304-318, 321-332, 335-341, 355
R/module_teal_data.R                149      10  93.29%   41-48, 84, 135-136
R/module_teal_lockfile.R            131      44  66.41%   32-36, 44-56, 59-61, 75, 85-87, 99-101, 109-118, 121, 123, 125-126, 160-161
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     190      87  54.21%   48-143, 158, 184-185, 217
R/module_transform_data.R            54      32  40.74%   17-52
R/modules.R                         280      72  74.29%   173-177, 232-235, 356-376, 384, 534-540, 553-562, 578-626, 659, 671-679
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 58       0  100.00%
R/teal_data_utils.R                  10       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           253      38  84.98%   405-454
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3253    1297  60.13%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 38a1f88

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Unit Tests Summary

  1 files   25 suites   9m 13s ⏱️
269 tests 265 ✅ 4 💤 0 ❌
524 runs  520 ✅ 4 💤 0 ❌

Results for commit 38a1f88.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $72.63$ $+2.16$ $0$ $0$ $0$ $0$
shinytest2-data_summary 💔 $51.60$ $+1.23$ $0$ $0$ $0$ $0$
shinytest2-reporter 💔 $67.58$ $+1.71$ $0$ $0$ $0$ $0$
shinytest2-teal_slices 💔 $60.90$ $+1.77$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-teal_slices 💔 $23.40$ $+1.33$ e2e_teal_slices_filters_are_initialized_when_global_filters_are_created

Results for commit 2af7ac0

♻️ This comment has been updated with latest results.

@averissimo averissimo self-assigned this Nov 18, 2024
averissimo
averissimo approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@m7pr m7pr merged commit 9e65126 into main Nov 19, 2024
28 checks passed
@m7pr m7pr deleted the m7pr-patch-1 branch November 19, 2024 07:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@averissimo averissimo averissimo approved these changes

@gogonzo gogonzo Awaiting requested review from gogonzo

Assignees

@averissimo averissimo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m7pr @averissimo